feat: exchange: change GetBlocks to always fetch the requested number of tipsets #11565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
commented
Jan 10, 2024
| } | ||
|
|
||
| return validRes.toFullTipSets()[0], nil | ||
| // If `doRequest` didn't fail we are guaranteed to have at least |
There was a problem hiding this comment.
This was true, but I still see no reason not to check this.
arajasek
commented
Jan 10, 2024
| // tipset *backwards*, returning as many tipsets as the count parameter, | ||
| // or less. | ||
| // tipset *backwards*, returning as many tipsets as the count parameter. | ||
| // The ONLY case in which we return fewer than `count` tipsets is if we hit genesis. | ||
| GetBlocks(ctx context.Context, tsk types.TipSetKey, count int) ([]*types.TipSet, error) | ||
|
|
||
| // GetChainMessages fetches messages from the network, starting from the first provided tipset |
There was a problem hiding this comment.
Note that we are NOT changing GetChainMessages behaviour -- it might still return fewer than count epochs worth of messages.
Stebalien
approved these changes
Jan 11, 2024
rjan90
pushed a commit
that referenced
this pull request
Jan 11, 2024
feat: exchange: change GetBlocks to always fetch the requested number of tipsets
rjan90
pushed a commit
that referenced
this pull request
Jan 11, 2024
feat: exchange: change GetBlocks to always fetch the requested number of tipsets
simlecode
pushed a commit
to ipfs-force-community/lotus
that referenced
this pull request
Jan 12, 2024
…arden-sync feat: exchange: change GetBlocks to always fetch the requested number of tipsets
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #11529
Proposed Changes
Change
GetBlocksto always returncounttipsets, unless we hit genesis. Partial responses are treated as correct, but the exchanger will still request more tipsets (instead of returning fewer than requested tipsets to the caller).Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps