Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: daemon: avoid prompting to remove chain when noninteractive #11582

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Stebalien
Copy link
Member

Related Issues

See https://github.com/filecoin-project/lotus/pull/11579/files#r1453900324

Proposed Changes

  1. Let the user specify --remove-existing-chain=false to avoid the prompt and fail if there's an existing chain.
  2. Only prompt when interactive. Otherwise, don't remove the chain by-default.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

1. Let the user specify `--remove-existing-chain=false` to avoid the
   prompt and fail if there's an existing chain.
2. Only prompt when interactive. Otherwise, _don't_ remove the chain
   by-default.
@Stebalien Stebalien requested a review from a team as a code owner January 16, 2024 19:21
@Stebalien Stebalien requested review from snissn and removed request for snissn January 17, 2024 20:09
@Stebalien Stebalien enabled auto-merge (squash) January 17, 2024 23:31
@Stebalien Stebalien merged commit 3685cb5 into master Jan 18, 2024
89 checks passed
@Stebalien Stebalien deleted the steb/remove-chain-prompt branch January 18, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants