chore: Set upgrade heights and change codename #11599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjan90
changed the title
rjan90
changed the title
rjan90
force-pushed
the
phi-butterfly-prep
branch
from
6179fe4
to
b95715b
Compare
rjan90
requested review from
Stebalien and
arajasek
and removed request for
a team
rjan90
force-pushed
the
phi-butterfly-prep
branch
2 times, most recently
from
a669b5d
to
7181cd3
Compare
rjan90
changed the title
rjan90
force-pushed
the
phi-butterfly-prep
branch
from
3e6db1c
to
be342eb
Compare
Update upgrade heights Co-Authored-By: Steven Allen <steven@stebalien.com>
rjan90
force-pushed
the
phi-butterfly-prep
branch
from
a203c73
to
3426289
Compare
arajasek
approved these changes
Feb 9, 2024
arajasek
reviewed
Feb 9, 2024
build/params_2k.go
Outdated
|
|
||
| var UpgradeMangoHeight = UpgradePineappleHeight + 10 | ||
| var UpgradeMangoHeight = UpgradeDragonHeight + 10 |
There was a problem hiding this comment.
Per discussion, we'll probably wind up going with something like + 100 instead. But that doesn't have to change in this PR.
There was a problem hiding this comment.
Updated to +100 in 9112e85.
There was a problem hiding this comment.
Do we also want the Drand switch to be +100 epochs away from the nv22 upgrade in the butterfly/calibration/mainnet ?
There was a problem hiding this comment.
Do we also want the Drand switch to be +100 epochs away from the nv22 upgrade in the butterfly/calibration/mainnet ?
We really only care about mainnet.
@arajasek can we make this 120 so it falls on an hour mark?
Update epoch after nv22 DRAND switch
Stebalien
approved these changes
Feb 13, 2024
| @@ -89,10 +89,10 @@ const UpgradeWatermelonFixHeight = 1070494 | |||
| // 2023-11-21T13:00:00Z | |||
| const UpgradeWatermelonFix2Height = 1108174 | |||
|
|
|||
| // ?????? | |||
| const UpgradePineappleHeight = 999999999999999 | |||
| // 2024-02-27T14:00:00Z | |||
Make the codename for the Drand-change inline with Dragon style.
Stebalien
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
1390534which is2024-02-27T14:00:00ZUpgradePhoenixHeightto 120 epochs after the nv22 upgrade.5760which is two days from reset, allowing for us to get some states in the network before the upgrade height.Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps