Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonytask feature: find clean-up work when underutilized. #11607

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

snadrus
Copy link
Contributor

@snadrus snadrus commented Feb 1, 2024

A helper for correct handling of different syncs for potential new harmony tasks. This will allow tasks to be created on demand of available resources so that both batching and non-batching processes can consume from the same inflow.

Proposed Changes

Pipelines' first steps can implement TaskDefinition.IAmBored to scrounge up more work when they have the capacity to work it.
Mid-pipeline stages can look at later failed stages for advanced recovery.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snadrus snadrus requested a review from a team as a code owner February 1, 2024 21:05
@jennijuju
Copy link
Member

please have better PR titles as lotus release notes are generated off them

@snadrus snadrus changed the title feat/boredom harmonytask feature: find clean-up work when underutilized. Feb 14, 2024
@snadrus
Copy link
Contributor Author

snadrus commented Feb 14, 2024

@magik6k

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I'm going to need that soon for some automatic GC processes

@magik6k magik6k enabled auto-merge (rebase) April 15, 2024 20:16
@magik6k magik6k merged commit 2dd7db2 into master Apr 16, 2024
181 of 186 checks passed
@magik6k magik6k deleted the feat/harmony-boredom branch April 16, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants