AggregateProofType nil when doing batch updates #11611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
requested review from
Stebalien and
magik6k
and removed request for
a team
|
|
magik6k
approved these changes
Feb 8, 2024
8 tasks
Use latest nv22 go-state-types version with matching update
rvagg
force-pushed
the
rvagg/optional-aggregate-proof-type
branch
from
d79ff6b
to
4ba1421
Compare
|
Pulled in the actors update from #11604 to here to get to green CI before merging. Two birds, one green stone. |
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@magik6k I don't know whether this is helpful or not but I needed this for what I was doing so here it is. It's currently using the branch @ filecoin-project/go-state-types#242. The cbor-gen changes here are immaterial, I just happened to update cbor-gen to master but the code it outputs should be essentially the same and that could even be backed out. The important change is in
storage/pipeline/commit_batch.go.I'm just not sure about
ProveReplicaUpdates3Params, you should probably look at storage/pipeline/states_replica_update.go and follow up on the work you did in #11226 on that?