Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci: use filecoin-ffi hash to cache make deps outputs #11961

Merged
merged 1 commit into from
May 3, 2024

Conversation

galargh
Copy link
Contributor

@galargh galargh commented May 3, 2024

Related Issues

#11897

Proposed Changes

Use filecoin-ffi head commit hash as a cache key for make deps outputs cache.

Additional Info

Previously, we were only taking into account install-filcrypto script and rustc-target-features-optimized.json, but we also have to account for changes in the rust directory. At this point, it's easier to use the hash of the entire repo into consideration.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@galargh galargh marked this pull request as ready for review May 3, 2024 15:49
@galargh galargh requested review from rjan90 and LexLuthr May 3, 2024 15:50
@galargh galargh merged commit b50049a into master May 3, 2024
186 checks passed
@galargh galargh deleted the ipdx/fix-make-deps-cache branch May 3, 2024 16:31
@rjan90 rjan90 mentioned this pull request May 6, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants