Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci: publish correct docker tags on workflow dispatch #12060

Merged
merged 1 commit into from
May 29, 2024

Conversation

galargh
Copy link
Contributor

@galargh galargh commented May 29, 2024

Related Issues

https://ipdx-workspace.slack.com/archives/CP50PPW2X/p1716967567670129

Proposed Changes

When the workflow is triggered manually, infer the sha and ref to use for generating Docker metadata from the git checkout instead of relying on the github context (which points to the git info of the version of the workflow we're using).

Additional Info

We didn't release the tag before because the tag release was tied to the tag push trigger only. I have now run the workflow again (from this branch) and verified the tag is being correctly pushed:

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Copy link

github-actions bot commented May 29, 2024

All checks have completed

⏭️ Skipped Check / Check (lint-all) (pull_request)
⏭️ Skipped Test / Test (itest-eth_filter) (pull_request)

@galargh galargh marked this pull request as ready for review May 29, 2024 09:39
@galargh galargh requested a review from rjan90 May 29, 2024 09:39
@galargh galargh merged commit cf8d187 into master May 29, 2024
99 checks passed
@galargh galargh deleted the ipdx/fix-docker-release branch May 29, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants