Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog]: fix: flaky eth_legacy_tx_test: wait for async msg indexing #12200

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

aarshkshah1992
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 commented Jul 9, 2024

Fixes the flaky TestLegacyContractInvocation test in eth_legacy_tx_test. The message indexing in the eth tx db happens async to submitting the transactions and so we need to wait for the submitted tx to be indexed before we can read it from the tx db.

@aarshkshah1992 aarshkshah1992 added the skip/changelog This change does not require CHANGELOG.md update label Jul 9, 2024
@aarshkshah1992 aarshkshah1992 changed the title [WIP] fix: flaky eth_legacy_tx_test: wait for async msg indexing [WIP] [skip changelog]: fix: flaky eth_legacy_tx_test: wait for async msg indexing Jul 9, 2024
@aarshkshah1992 aarshkshah1992 changed the title [WIP] [skip changelog]: fix: flaky eth_legacy_tx_test: wait for async msg indexing [skip changelog]: fix: flaky eth_legacy_tx_test: wait for async msg indexing Jul 9, 2024
@aarshkshah1992 aarshkshah1992 requested a review from rvagg July 9, 2024 09:56
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@aarshkshah1992 aarshkshah1992 merged commit cb953b1 into master Jul 9, 2024
81 of 83 checks passed
@aarshkshah1992 aarshkshah1992 deleted the fix/flaky-legacy-eth-tx-test branch July 9, 2024 10:05
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Jul 17, 2024
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants