Check for correct nonce before taking gas #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise as a miner you are able to include an invalid message forever and get whole GasLimit of gas from it every time. Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
|
@Kubuxu this LGTM, but does it match the spec? We might have some updating to do there |
|
( I can handle the updating if necessary) |
|
IDK where in spec to look. |
|
@Kubuxu no worries, i'll look for it. no reason to block merging now though |
whyrusleeping
approved these changes
Mar 11, 2020
Kubuxu
pushed a commit
that referenced
this pull request
May 12, 2020
Check for correct nonce before taking gas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise as a miner you are able to include an invalid message forever
and get whole GasLimit of gas from it every time.