Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windowed PoSt #1522

Merged
merged 70 commits into from
Apr 21, 2020
Merged

Windowed PoSt #1522

merged 70 commits into from
Apr 21, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 7, 2020 •
edited

Related PRs:

This was referenced Apr 10, 2020
Merged
Merged
@shannonwells shannonwells mentioned this pull request Apr 20, 2020
Merged
whyrusleeping
whyrusleeping reviewed Apr 21, 2020
View reviewed changes
chain/gen/gen.go Outdated Show resolved Hide resolved
whyrusleeping
whyrusleeping approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I left a few nitpicky comments, but the scheduling logic appears to be correct (assuming the specs actors stuff underlying it is correct)

arajasek
arajasek approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the logic seems correct enough to me :)

chain/gen/genesis/genesis.go
// Create verified registry
verifact, err := SetupVerifiedRegistryActor(bs)
if err != nil {
return nil, xerrors.Errorf("setup storage market actor: %w", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix error messages (and the ones above, I guess, there's a lot of copypasting).

@magik6k magik6k merged commit 3bbbefd into testnet/3 Apr 21, 2020
Kubuxu pushed a commit that referenced this pull request May 12, 2020
@magik6k
Merge pull request #1522 from filecoin-project/feat/windowed-post
4d5e320 
Windowed PoSt
@Kubuxu Kubuxu deleted the feat/windowed-post branch May 28, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@arajasek arajasek arajasek approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magik6k @whyrusleeping @arajasek