VerifyConsensusFault syscall impl #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sternhenri
changed the title
Kubuxu
reviewed
Apr 16, 2020
chain/vm/syscalls.go
Outdated
| return nil, xerrors.Errorf("cannot decode extra: %w", decodeErr) | ||
| } | ||
|
|
||
| if types.CidArrsEqual(blockA.Parents, blockC.Parents) && blockA.Height == blockB.Height && |
There was a problem hiding this comment.
from what I'm reading, a.Height and b.Height will be always different in this case, code says something else.
also with that check it would be a more restricted case (a)
There was a problem hiding this comment.
ah typo, it is blockA.Height == blockC.Height. Great catch.
Do you see how it's different from a?
There was a problem hiding this comment.
yeah, now it makes sense.
sternhenri
force-pushed
the
patch/syscalls
branch
from
bdc8585
to
93a4c36
Compare
whyrusleeping
approved these changes
Apr 16, 2020
Kubuxu
pushed a commit
that referenced
this pull request
May 12, 2020
VerifyConsensusFault syscall impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This impl is heavily based on the structure of https://github.com/filecoin-project/go-filecoin/blob/d75e700d2b5b116a794c3da672d6379bcb24b803/internal/pkg/slashing/check.go#L40.
A few things to note:
Contains) based on CIDs rather than tipsets given the headers submitted toVerifyConsensusFaultmay be invalid (and yet the faults themselves may not be).VerifySignatureinstead of makingVerifyBlockSig