Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better mining tests, Fix no-sector miner panic #1590

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 23, 2020

No description provided.

Comment on lines +307 to +310
if mbi == nil {
base.NullRounds++
return nil, nil
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the panic when attempting to mine with no sectors

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres more cleanup to do on those tests, and I think I want a lot more of them, but this is a strict improvement, so lets get it in

@magik6k magik6k merged commit 0ec0786 into testnet/3 Apr 23, 2020
@magik6k magik6k deleted the feat/newminer branch April 23, 2020 22:14
Kubuxu pushed a commit that referenced this pull request May 12, 2020
Better mining tests, Fix no-sector miner panic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants