integrating storage market actor, includes cross actor messaging #26
Conversation
whyrusleeping
force-pushed
the
feat/storage-market-actor
branch
from
98c050e
to
c5e9a8a
Compare
chain/actor_storagemarket.go
Outdated
| PeerID peer.ID | ||
| } | ||
|
|
||
| func (p *CreateStorageMinerParams) UnmarshalCBOR(b []byte) (int, error) { |
There was a problem hiding this comment.
having to define this on every struct kinda sucks...
There was a problem hiding this comment.
Yeah, I can probably call these functions on the object passed there. How does that sound?
| @@ -1,9 +1,11 @@ | |||
| package chain | |||
| package actors_test | |||
There was a problem hiding this comment.
If you name this package actors you don't need dot import.
There was a problem hiding this comment.
We can't do this because of import loop.
There was a problem hiding this comment.
theres a circular import i think that won't work
chain/actors/actor_storagemarket.go
Outdated
| } | ||
|
|
||
| func SupportedSectorSize(ssize types.BigInt) bool { | ||
| if ssize.Uint64() == 1024 { |
There was a problem hiding this comment.
I'd put it in a constant (possibly in the /build package for build-time constants)
chain/actors/actor_storagemarket.go
Outdated
| } | ||
|
|
||
| func (p *CreateStorageMinerParams) UnmarshalCBOR(b []byte) (int, error) { | ||
| if err := cbor.DecodeInto(b, p); err != nil { |
There was a problem hiding this comment.
Technically we could dedupe this bit of code across actors with tiny helper
func unmarshalCBOR(p interface{}, b []byte) (int, error) {
if err := cbor.DecodeInto(b, p); err != nil {
return 0, err
}
return len(b), nil
}
func (p *CreateStorageMinerParams) UnmarshalCBOR(b []byte) (int, error) {
return unmarshalCBOR(p, b)
}There was a problem hiding this comment.
I've made that code not needed with #29
| PeerID peer.ID | ||
| } | ||
|
|
||
| func (sma StorageMinerActor) StorageMinerActor(act *types.Actor, vmctx types.VMContext, params *StorageMinerConstructorParams) (types.InvokeRet, error) { |
There was a problem hiding this comment.
This looks like we could use some reflection here (but probably shouldn't, doesn't seem worth it).
There was a problem hiding this comment.
What do you mean @magik6k ?
There was a problem hiding this comment.
We could set tags on fields in StorageMinerActor to generate params struct, and this constructor
There was a problem hiding this comment.
Constructors will frequently perform checks and so on so I would say generating this isn't really useful.
Now invoker is calling CBOR directly. License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Fix a mistake in checkPrecommit
No description provided.