Introduce dynamic network fee #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 6, 2020 21:14
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Kubuxu
force-pushed
the
feat/dyn-base-fee
branch
from
d227d7c
to
6562b7a
Compare
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
magik6k
force-pushed
the
feat/dyn-base-fee
branch
from
a288825
to
07bf155
Compare
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
magik6k
reviewed
Aug 6, 2020
| ) | ||
|
|
||
| func (cs *ChainStore) ComputeBaseFee(ctx context.Context, ts *types.TipSet) (abi.TokenAmount, error) { | ||
| zero := abi.NewTokenAmount(0) |
There was a problem hiding this comment.
thre is big.Zero but I don't import it
added 3 commits
August 7, 2020 01:57
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
magik6k
reviewed
Aug 7, 2020
magik6k
reviewed
Aug 7, 2020
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
magik6k
reviewed
Aug 7, 2020
| chains = append(chains, next...) | ||
| } | ||
|
|
||
| // 2. Sort the chains | ||
| sort.Slice(chains, func(i, j int) bool { | ||
| return chains[i].Before(chains[j]) | ||
| }) | ||
| if len(chains) != 0 && chains[0].gasPerf < 0 { |
There was a problem hiding this comment.
Looks like we may still end up including chains with negative gasPerf here
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
magik6k
reviewed
Aug 7, 2020
magik6k
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.