Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some more tracing to chain sync #323

Merged
merged 2 commits into from
Oct 11, 2019
Merged

add some more tracing to chain sync #323

merged 2 commits into from
Oct 11, 2019

Conversation

whyrusleeping
Copy link
Member

No description provided.

chain/sync.go Outdated
@@ -15,6 +15,7 @@ import (
"github.com/filecoin-project/go-lotus/chain/stmgr"
"github.com/filecoin-project/go-lotus/chain/store"
"github.com/filecoin-project/go-lotus/chain/types"
"go.opencensus.io/trace"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: import order

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit, lgtm after

@magik6k magik6k merged commit 177a876 into master Oct 11, 2019
@magik6k magik6k deleted the feat/tracing-1 branch October 11, 2019 02:19
Copy link

All checks have passed

@galargh
Copy link
Contributor

galargh commented Apr 22, 2024

All checks have passed

Looking into why we commented on this 5 years old PR 😕

@jennijuju
Copy link
Member

All checks have passed

Looking into why we commented on this 5 years old PR 😕

To get @whyrusleeping ’s attention probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants