Fix panic in OnDealExpiredSlashed #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check for nil tipset when check func is called to avoid panic
Kubuxu
approved these changes
Sep 4, 2020
magik6k
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
The markets client node adapter is crashing in OnDealExpiredSlashed when a nil tipset is passed to check func
Implementation
Just skip checkFunc logic when nil tipset is passed -- similar to #3011
We should figure out why the events_called interface is passing nil tipsets to CheckFunc. I think there may be a bug in the tipset cache logic