Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote wallet backends #3583

Merged
merged 18 commits into from
Oct 10, 2020
Merged

Remote wallet backends #3583

merged 18 commits into from
Oct 10, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 5, 2020

This implements #2016, not fully done yet, and has some ux bugs, but it should generally work

@whyrusleeping
Copy link
Member

It's like magic.

@magik6k magik6k self-assigned this Sep 6, 2020
@arash009
Copy link

Looking forward to this getting in.

@magik6k
Copy link
Contributor Author

magik6k commented Oct 4, 2020

Depends on HTTP JsonRPC client support -> filecoin-project/go-jsonrpc#30

@magik6k magik6k marked this pull request as ready for review October 9, 2020 01:05
@magik6k
Copy link
Contributor Author

magik6k commented Oct 9, 2020

It Works!

screencap 2020-10-09T02:47:12Z

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great! Lets land it!

@magik6k magik6k merged commit a6d9b30 into master Oct 10, 2020
@magik6k magik6k deleted the feat/signing-backends branch October 10, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants