Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add expected height metric #3586

Merged
merged 2 commits into from Sep 7, 2020
Merged

metrics: add expected height metric #3586

merged 2 commits into from Sep 7, 2020

Conversation

travisperson
Copy link
Contributor

@travisperson travisperson commented Sep 6, 2020 •
edited

Exports the expected height of the node based off of the current time, block delay and the genesis timestamp.

Between the following stats we should be able to get some pretty good information about the status of a node with regard to it's chain

# HELP lotus_chain_node_height Current Height of the node
# TYPE lotus_chain_node_height gauge
lotus_chain_node_height 35354
# HELP lotus_chain_node_height_expected Expected Height of the node
# TYPE lotus_chain_node_height_expected gauge
lotus_chain_node_height_expected 35354
# HELP lotus_chain_node_worker_height Current Height of workers on the node
# TYPE lotus_chain_node_worker_height gauge
lotus_chain_node_worker_height 35354

image

magik6k
magik6k reviewed Sep 6, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits, really like the idea though

chain/sync.go Outdated Show resolved Hide resolved
chain/sync.go Outdated Show resolved Hide resolved
chain/sync.go Outdated Show resolved Hide resolved
magik6k
magik6k previously approved these changes Sep 7, 2020
View reviewed changes
@magik6k magik6k merged commit 758aae8 into master Sep 7, 2020
@magik6k magik6k deleted the feat/expected-height-metric branch September 7, 2020 17:09
@snyk-bot snyk-bot mentioned this pull request Feb 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@placer14 placer14 Awaiting requested review from placer14

@lanzafame lanzafame Awaiting requested review from lanzafame

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travisperson @magik6k