Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: return true from Sealer.ReadPiece() on success #3657

Merged
merged 1 commit into from
Sep 8, 2020
Merged

storage: return true from Sealer.ReadPiece() on success #3657

merged 1 commit into from
Sep 8, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Sep 8, 2020

Currently Sealer.ReadPiece() always returns false. This PR changes it to return true on success.

magik6k
magik6k approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That explains a lot, including needing a worker to run unsealing tasks even with the data already unsealed

@magik6k magik6k merged commit e87ccbf into fix/stgmgr-undef-unsealed Sep 8, 2020
@magik6k magik6k deleted the fix/stg-sealer-read-piece branch September 8, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirkmc @magik6k