add an auto flag to mpool replace #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisperson
reviewed
Sep 8, 2020
| if err != nil { | ||
| return fmt.Errorf("parsing gas-feecap: %w", err) | ||
| if cctx.Bool("auto") { | ||
| // msg.GasLimit = 0 // TODO: need to fix the way we estimate gas limits to account for the messages already being in the mempool |
There was a problem hiding this comment.
max(msg.GasLimit + 1, GasEstimateGasLimit)?
travisperson
approved these changes
Sep 8, 2020
magik6k
reviewed
Sep 9, 2020
cli/mpool.go
Outdated
| return fmt.Errorf("failed to estimate gas values: %w", err) | ||
| } | ||
| msg.GasFeeCap = retm.GasFeeCap | ||
| msg.GasPremium = retm.GasPremium |
There was a problem hiding this comment.
Needs to check if this is high enough for replace-by-fee
magik6k
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.