Add get-ask, set-ask retrieval commands #3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingar
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
ingar
force-pushed
the
feat/retrieval-set-get-ask
branch
from
8c820ed
to
71e48f7
Compare
|
FYI I don't see this conflicting with actors upgrade so it's probably fine to merge |
ingar
force-pushed
the
feat/retrieval-set-get-ask
branch
from
71e48f7
to
2aef7f7
Compare
magik6k
reviewed
Sep 16, 2020
| if err != nil { | ||
| return err | ||
| } | ||
| ask.PricePerByte = abi.TokenAmount(v) |
There was a problem hiding this comment.
That's per byte, but above we the comment says per GiB.
We could change the comment, but i think it's better ux to actually have it be per GiB, so we just need to divide here by 1 << 30
magik6k
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Expose
MarketGetRetrievalAsk,MarketSetRetrievalAskAPIs via the CLI.The
set-askcommand allows you to modify any or all parameters of the current ask.Resolves #3843