Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add logging to chain export #4030

Merged
merged 1 commit into from
Sep 26, 2020
Merged

add logging to chain export #4030

merged 1 commit into from
Sep 26, 2020

Conversation

travisperson
Copy link
Contributor

@travisperson travisperson commented Sep 25, 2020 •
edited

travisperson
travisperson commented Sep 25, 2020
View reviewed changes
chain/store/store.go
currentMinHeight = b.Height
if currentMinHeight%builtin.EpochsInDay == 0 {
log.Infow("export", "height", currentMinHeight)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be the best check as it can easily be skipped due to null rounds but it's really just here to give a basic idea and I doubt it would get skipped frequently enough to really need something better, but open to suggestions.

@magik6k magik6k changed the base branch from master to dev September 26, 2020 08:10
@magik6k magik6k merged commit 3fe0aa5 into dev Sep 26, 2020
@magik6k magik6k deleted the feat/export-logging branch September 26, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide logging details for chain export
2 participants
@travisperson @magik6k