Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize Tipset equals #4056

Merged
merged 2 commits into from
Sep 28, 2020
Merged

optimize Tipset equals #4056

merged 2 commits into from
Sep 28, 2020

Conversation

zgfzgf
Copy link
Contributor

@zgfzgf zgfzgf commented Sep 27, 2020

add height equal
cids instead of blks

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, this code can be traced back all the way back to the f2 prototype

The change looks good/safe to me, though I'd like @whyrusleeping to also approve this

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Kubuxu Kubuxu merged commit 2633198 into filecoin-project:master Sep 28, 2020
@zgfzgf zgfzgf deleted the tipset-equals branch September 28, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants