Markets 0.7.0 with updated data stores #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
feat/update-markets-0.7.0
branch
from
e654162
to
176412e
Compare
arajasek
approved these changes
Sep 30, 2020
hannahhoward
force-pushed
the
feat/update-markets-0.7.0
branch
from
176412e
to
be884e2
Compare
hannahhoward
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
| storedAsk, err := storedask.NewStoredAsk(namespace.Wrap(ds, datastore.NewKey("/deals/provider")), datastore.NewKey("latest-ask"), spn, address.Address(minerAddress)) | ||
| providerDs := namespace.Wrap(ds, datastore.NewKey("/deals/provider")) | ||
| // legacy this was mistake where this key was place -- so we move the legacy key if need be | ||
| err = shared.MoveKey(providerDs, "/latest-ask", "/storage-ask/latest") |
There was a problem hiding this comment.
Do we want to run this every time?
There was a problem hiding this comment.
I mean it's a no-op unless it hasn't already been moved. We'll remove the code once everyone is no 0.8.1 or 0.9.0
whyrusleeping
approved these changes
Sep 30, 2020
magik6k
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Upgrade to markets 0.7.0, which moves all datastores and protocols to CBOR map-encoding, in a legacy compatible way
Implementation