fix: return true when deadlines changed #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
10 tasks
magik6k
approved these changes
Oct 14, 2020
|
test failures appear to be unrelated/flaky. |
magik6k
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method name
DeadlinesChangedsuggests it will return true when the deadlines have changed when in fact it returns false. This PR addresses this by having the methods return true when the deadlines have changed. The methodDeadlinesChnagedis called in chainwatch and inDiffDeadlines. Neither of these methods are called in lotus.A similar issue exists for
PartitionsChangedas well that has been addressed here.