reduce garbage in blockstore #4406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can't possibly be valid messages, so we should just drop the block.
Instead of using an in-memory datastore and dealing with the overhead of computing datastore keys, creating new blocks, etc, use an in-memory blockstore.
This blockstore lets us write to a temporary scratch location where blocks older than the specified cache time are automatically cleared.
If they end up validating, we'll write them back to the underlying blockstore. Otherwise, there's no reason to keep them.
Stebalien
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
| // We use a temporary bstore here to avoid writing intermediate pieces | ||
| // into the blockstore. | ||
| blockstore := bstore.NewTemporary() | ||
| cst := cbor.NewCborStore(blockstore) |
There was a problem hiding this comment.
Can the comments on 326-328 be removed? I believe this addresses them.
There was a problem hiding this comment.
I think they're still valid? That is, at this point we know we have a "sane" block, but it may not be otherwise valid.
But I don't know the original intention of that comment.
Kubuxu
approved these changes
Oct 14, 2020
magik6k
approved these changes
Oct 14, 2020
Kubuxu
approved these changes
Oct 14, 2020
whyrusleeping
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid writing messages/blocks that may not be useful to the blockstore until we've validated them.