Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure msig inspect cli works with lotus-lite #4421

Merged
merged 3 commits into from Oct 15, 2020
Merged

Ensure msig inspect cli works with lotus-lite #4421

merged 3 commits into from Oct 15, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Oct 15, 2020

This PR

  • Creates a basic CLI test for msig create & msig inspect
  • Adds hooks to run the test
    • from CLI with a regular node
    • from api-gateway with lite node -> gateway -> full node

Now that the framework is in place, it should be easy to add other CLI commands to the basic msig CLI test to ensure they run in regular and lite mode.

magik6k
magik6k approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works great locally!

Also really good to get tests for multisig CLI

@magik6k magik6k merged commit c56ef26 into master Oct 15, 2020
@magik6k magik6k deleted the fix/lite-msig-inspect branch October 15, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirkmc @magik6k