Make state tipset usage consistent in the API #4545

Stebalien · 2020-10-22T19:18:02Z

Always (almost) use the tipset's parent state, instead of computing.

Exceptions:

MinerGetBaseInfo. Fixing this would break things so we need to be careful (although we could bump the API version, fix it, then fix the call sites).
StateReplay. This is replaying a message on top of the given tipset.
GasEstimateGasLimit. This executes the message on-top-of the tipset's computed state (unlike call which executes it on the tipset's parent state).
- Having this method and Call apply the message at different heights is really weird.

Stebalien · 2020-10-22T19:33:15Z

The test failures look problematic.

(resolved)

Stebalien · 2020-10-23T03:12:15Z

chain/stmgr/utils.go

@@ -144,20 +144,6 @@ func MinerSectorInfo(ctx context.Context, sm *StateManager, maddr address.Addres
 	return mas.GetSector(sid)
 }

-func GetMinerSectorSet(ctx context.Context, sm *StateManager, ts *types.TipSet, maddr address.Address, snos *bitfield.BitField) ([]*miner.SectorOnChainInfo, error) {


This was a drive-by fix. Removed because it was only being used in one place at this point.

Stebalien · 2020-10-23T03:12:42Z

miner/miner.go

-	err error
-}
-
-type cachedActorLookup struct {


Stebalien · 2020-10-23T03:13:17Z

node/impl/full/state.go

@@ -109,7 +108,7 @@ func (a *StateAPI) StateMinerActiveSectors(ctx context.Context, maddr address.Ad
 		return nil, xerrors.Errorf("merge partition active sets: %w", err)
 	}

-	return stmgr.GetMinerSectorSet(ctx, a.StateManager, ts, maddr, &activeSectors)
+	return mas.LoadSectors(&activeSectors)


This avoids loading the actor twice.

node/modules/mpoolnonceapi.go

Stebalien · 2020-10-23T03:16:53Z

The tests pass but there are still outstanding questions.

arajasek · 2020-11-12T21:21:14Z

1.2.1 is probably the right release for this, after careful review and letting it run on our nodes for a while

_Always_ (almost) use the tipset's parent state, instead of computing. Exceptions: * MinerGetBaseInfo. Fixing this would break things so we need to be careful (although we could bump the API version, fix it, then fix the call sites). * StateReplay. This is replaying a message on top of the given tipset. * GasEstimateGasLimit. This executes the message on-top-of the tipset's computed state (unlike call which executes it on the tipset's parent state). * Having this method and Call apply the message at different heights is really weird.

… the tipset We could also do this in the message pool itself, but I'm not sure if it's worth it?

StateGetActor now gets the actor at the tipset parent state.

…stent-tipset-methods

magik6k

Would be nice to finally land this.

Not entirely sure why, but tests fail on latest master with this

magik6k · 2021-01-30T11:22:59Z

node/modules/mpoolnonceapi.go

-	return act.Nonce, nil
+	for _, msg := range msgs {
+		vmmsg := msg.VMMessage()
+		if vmmsg.From != keyAddr {


I think msg.From can technically also be an ID address, though I don't see messages like that on-chain

You sure? It looks like message verification will fail if the from address is not a public key.

lotus/chain/messagepool/messagepool.go

Lines 635 to 637 in 4937fb9

if err := sigs.Verify(&m.Signature, m.Message.From, m.Message.Cid().Bytes()); err != nil {

return err

}

Uff we should fix it.

yeah, you should abosolutely be able to send a message with an ID address as the from

Well, we can add that to the network upgrade. Note: we'll need to carefully check the VM to make sure we resolve everything as expected before passing it off to the actors.

Note: we currently implicitly resolve the from address when sending. Should we not be doing that?

node/modules/mpoolnonceapi.go

Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>

…stent-tipset-methods

magik6k

Looks good. Also did some manual testing and everything appears to work well

…efactor-consistent-tipset-methods Make state tipset usage consistent in the API

Stebalien requested review from Kubuxu, magik6k and whyrusleeping as code owners October 22, 2020 19:18

Stebalien marked this pull request as draft October 22, 2020 19:32

Stebalien force-pushed the steb/refactor-consistent-tipset-methods branch 2 times, most recently from 21e13ef to c6a7c6d Compare October 23, 2020 01:38

Stebalien commented Oct 23, 2020

View reviewed changes

Stebalien force-pushed the steb/refactor-consistent-tipset-methods branch 2 times, most recently from 3188820 to 0b37dda Compare October 26, 2020 17:46

Stebalien marked this pull request as ready for review October 26, 2020 17:47

frrist mentioned this pull request Nov 2, 2020

Make StateGetActor consistent and performant. filecoin-project/lily#196

Closed

7 tasks

frrist mentioned this pull request Nov 18, 2020

Fix off by one in actor state change processor filecoin-project/lily#238

Closed

Stebalien force-pushed the steb/refactor-consistent-tipset-methods branch from 0b37dda to 6d1ac1e Compare November 20, 2020 23:40

Stebalien added 4 commits December 9, 2020 11:29

Compute the next nonce from the tipset, instead of actually executing…

e164dbb

… the tipset We could also do this in the message pool itself, but I'm not sure if it's worth it?

Fix duplicate nonce test

a47b063

StateGetActor now gets the actor at the tipset parent state.

update docs

b78b9a4

Stebalien force-pushed the steb/refactor-consistent-tipset-methods branch from 6d1ac1e to b78b9a4 Compare December 9, 2020 19:29

Merge remote-tracking branch 'origin/master' into steb/refactor-consi…

56a9d05

…stent-tipset-methods

magik6k reviewed Jan 30, 2021

View reviewed changes

Stebalien and others added 5 commits January 30, 2021 10:18

choose the correct nonce

feb24c9

Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>

bump api version

52bfed1

Merge remote-tracking branch 'origin/master' into steb/refactor-consi…

8f60371

…stent-tipset-methods

skip TestDealMining in short mode

2c772d6

docsgen

33c1283

magik6k approved these changes Feb 5, 2021

View reviewed changes

magik6k merged commit ec58099 into master Feb 5, 2021

magik6k deleted the steb/refactor-consistent-tipset-methods branch February 5, 2021 20:57

bibibong pushed a commit to EpiK-Protocol/go-epik that referenced this pull request Feb 22, 2021

Merge pull request filecoin-project#4545 from filecoin-project/steb/r…

ef079d3

…efactor-consistent-tipset-methods Make state tipset usage consistent in the API

raynaudoe mentioned this pull request Mar 2, 2021

Update lotus V1.5 Zondax/rosetta-filecoin-proxy#131

Merged

jleni mentioned this pull request Mar 2, 2021

Proxy should check and abort if version <1.5.0 Zondax/rosetta-filecoin-proxy#134

Closed

hsanjuan mentioned this pull request Mar 2, 2021

Remove Parent.State logic introduced in #196 filecoin-project/lily#405

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make state tipset usage consistent in the API #4545

Make state tipset usage consistent in the API #4545

Stebalien commented Oct 22, 2020

Stebalien commented Oct 22, 2020 •

edited

Stebalien Oct 23, 2020

Stebalien Oct 23, 2020

Stebalien Oct 23, 2020

Stebalien commented Oct 23, 2020

arajasek commented Nov 12, 2020

magik6k left a comment

magik6k Jan 30, 2021

Stebalien Jan 30, 2021

Kubuxu Feb 2, 2021

whyrusleeping Feb 4, 2021

Stebalien Feb 5, 2021

Stebalien Feb 5, 2021

magik6k left a comment

	if err := sigs.Verify(&m.Signature, m.Message.From, m.Message.Cid().Bytes()); err != nil {
	return err
	}

Make state tipset usage consistent in the API #4545

Make state tipset usage consistent in the API #4545

Conversation

Stebalien commented Oct 22, 2020

Stebalien commented Oct 22, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Stebalien commented Oct 23, 2020

arajasek commented Nov 12, 2020

magik6k left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

magik6k left a comment

Choose a reason for hiding this comment

Stebalien commented Oct 22, 2020 •

edited