Fetch worker key from correct block on sync #4573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
There's no need to call TipSetState and recompute it.
We need to use the worker key from the lookback tipset state. We can't reasonably maintain this cache, unfortunately (unless we kept some form of "per-height" cache).
Stebalien
force-pushed
the
steb/remove-worker-key-cache
branch
from
dd00c46
to
06af2fb
Compare
arajasek
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syncing (via pubsub) from peers that have recently changed their worker key, we may have the wrong version cached (and/or we may have fetched it from the wrong epoch). This could cause us to mis-validate the block in the pubsub validator (either accept/reject it).
This won't cause state mismatches or forks (everything is re-checked later), but could cause nodes to propagate invalid blocks and/or refuse to propagate valid blocks.