Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add chain base64 decode params #4748

Merged
merged 2 commits into from
Nov 13, 2020
Merged

add chain base64 decode params #4748

merged 2 commits into from
Nov 13, 2020

Conversation

zgfzgf
Copy link
Contributor

@zgfzgf zgfzgf commented Nov 6, 2020

fix #4747

@arajasek
Copy link
Contributor

arajasek commented Nov 6, 2020

Thanks for the PR! I think it'd be best if we also supported hex-encoded params. Can you perhaps add an optional --encoding flag that can only take the values hex or base64? If the flag is omitted, default to base64.

@jennijuju
Copy link
Member

also resolves #4695

@jennijuju jennijuju linked an issue Nov 6, 2020 that may be closed by this pull request
decode params with b64 params input #4695
Closed
@jennijuju jennijuju mentioned this pull request Nov 11, 2020
Closed
@arajasek arajasek merged commit 6667220 into filecoin-project:master Nov 13, 2020
@zgfzgf zgfzgf deleted the fix-chain-decode-params branch November 14, 2020 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@magik6k magik6k Awaiting requested review from magik6k

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lotus chain decode params should be add base64 format decode params with b64 params input
3 participants
@zgfzgf @arajasek @jennijuju