Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize code replace strings with constants #4769

Merged
merged 1 commit into from
Nov 9, 2020
Merged

optimize code replace strings with constants #4769

merged 1 commit into from
Nov 9, 2020

Conversation

zgfzgf
Copy link
Contributor

@zgfzgf zgfzgf commented Nov 9, 2020

add ReturnType const

whyrusleeping
whyrusleeping approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That oughta help us avoid typos in the future

@magik6k magik6k merged commit f313835 into filecoin-project:master Nov 9, 2020
@zgfzgf zgfzgf deleted the feat-storage-work-returntype branch December 4, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zgfzgf @whyrusleeping @Kubuxu @magik6k