Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Balancing #4830

Merged
merged 10 commits into from
Nov 18, 2020
Merged

Gas Balancing #4830

merged 10 commits into from
Nov 18, 2020

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Nov 12, 2020

No description provided.

@Kubuxu Kubuxu added this to the 🚢Lotus v1.2.0 milestone Nov 12, 2020
@Kubuxu Kubuxu mentioned this pull request Nov 12, 2020
@Kubuxu
Copy link
Contributor Author

Kubuxu commented Nov 12, 2020

Not able to change GasOnSubmitVerifySeal we need cooperation form actors.

@magik6k magik6k added the impact/consensus Impact: Consensus label Nov 12, 2020
@magik6k magik6k changed the base branch from master to release/v1.2.0 November 12, 2020 18:13
@Kubuxu
Copy link
Contributor Author

Kubuxu commented Nov 12, 2020

Depends on: filecoin-project/specs-actors#1301

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Nov 16, 2020

Depends on updateing actos to filecoin-project/specs-actors#1303

chain/vm/runtime.go Outdated Show resolved Hide resolved
@arajasek
Copy link
Contributor

Depends on updateing actos to filecoin-project/specs-actors#1303

This is probably fine to go in with actors 2.3.0, which is what's in the destination branch. 2.3.0 includes neither filecoin-project/specs-actors#1301 nor its reverting in filecoin-project/specs-actors#1303.

@Kubuxu Kubuxu marked this pull request as ready for review November 17, 2020 12:27
@Kubuxu
Copy link
Contributor Author

Kubuxu commented Nov 17, 2020

The risk going with actors v2.3.0 is that anyone can accidentally update it to v2.3.1

@Kubuxu Kubuxu force-pushed the time/vm-flush branch 4 times, most recently from 816e227 to a567b2d Compare November 17, 2020 19:41
Jakub Sztandera and others added 8 commits November 17, 2020 20:41
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magik6k
Copy link
Contributor

magik6k commented Nov 17, 2020

(just need fixing tests)

@magik6k magik6k merged commit c5470ee into release/v1.2.0 Nov 18, 2020
@magik6k magik6k deleted the time/vm-flush branch November 18, 2020 00:34
@Kubuxu Kubuxu mentioned this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/consensus Impact: Consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants