fix(sync): enforce fork len when changing head #5244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
force-pushed
the
schomatis/fix/enforce-fork-len
branch
from
d7a8445
to
378af46
Compare
|
Failing flaky |
Kubuxu
approved these changes
Jan 12, 2021
|
Uff, IDK how I feel about merging this after RC is already out. |
|
I'm fine reverting but someone needs to own that this does get merged eventually please. |
bibibong
pushed a commit
to EpiK-Protocol/go-epik
that referenced
this pull request
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #5182 this PR is theoretically protocol breaking but the only case of interest is when we are working with forks close to finality threshold (which is orders of magnitude away from normal forks observed in the chain).
Most of the syncing logic seems to assume the "heaviest" tipset it receives as input is actually the head of our synced chain even if the lock is released. This is mostly innocuous and will be handled in follow-up PRs (to make this more explicit), but there are cases when we actually want to hold the lock while doing certain checks that are not related to the validity/integrity of a chain (either heaviest or not), namely how far away it is from the actual head we will be swapping it for (there may be other cases we should look into).