README: Contribute section #5330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
requested review from
vyzo,
whyrusleeping,
Kubuxu,
magik6k,
arajasek and
jennijuju
Kubuxu
approved these changes
Jan 12, 2021
vyzo
approved these changes
Jan 12, 2021
| The lotus Filecoin implementation unfolds into the following packages: | ||
| 1. If the proposal entails a protocol change, please first submit a [Filecoin Improvement Proposal](https://github.com/filecoin-project/FIPs). | ||
| 2. If the change is complex and requires prior discussion, [open an issue](github.com/filecoin-project/lotus/issues) or a [discussion](https://github.com/filecoin-project/lotus/discussions) to request feedback before you start working on a pull request. This is to avoid disappointment and sunk costs, in case the change is not actually needed or accepted. | ||
| 3. Please refrain from submitting PRs to adapt existing code to subjective preferences. |
schomatis
approved these changes
Jan 12, 2021
magik6k
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of the Contribute section in the README. The goal is to set the right expectations for contributors, and to help them submit useful PRs that have a high likelihood of being accepted.
It also removes the branch listing, and fixes some text. There is still outdated text in the README, but I'm choosing not to address it now to keep this PR simple.