Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export vm.ShouldBurn #5355

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

iand
Copy link
Contributor

@iand iand commented Jan 14, 2021

Required for sentinel to calculate gas outputs for each message.

There is some noise caused by gofumpt formatting of the file.

Comment on lines +46 to +50
var (
log = logging.Logger("vm")
actorLog = logging.Logger("actors")
gasOnActorExec = newGasCharge("OnActorExec", 0, 0)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would introduce formatting changes in separate PRs, so that future git blames can be less noisy and more accurate. But this is OK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to revert the formatting if you prefer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries.

@iand
Copy link
Contributor Author

iand commented Jan 14, 2021

Can't merge without a code owner approval.

@raulk
Copy link
Member

raulk commented Jan 14, 2021

Need to wait for @magik6k or @Kubuxu.

@raulk raulk merged commit 5453e70 into filecoin-project:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants