Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miner config to always keep ensealed deal copies #5433

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jan 26, 2021

Allows miners to set

[Sealing]
AlwaysKeepUnsealedCopy = true

in lotus-miner configs, to keep copies of deals even if those deals don't have the FastRetrieval flag set. By doing this miners can avoid having to unseal sectors while still being able to provide retrieval

@f8-ptrk
Copy link
Contributor

f8-ptrk commented Jan 27, 2021

#5435

a "never keep" flag, the opposite of AlwaysKeepUnsealedCopy = true would be nice, not sure if it needs a second flag or another one for "let the client choose" then

@f8-ptrk
Copy link
Contributor

f8-ptrk commented Jan 27, 2021

in addition: it might be worth thinking about an extra folder for these "sealed"-unsealed sectors so miners can link storage to the folder that doesn't need to be local and does not interfere with the "normal" unsealed folder

we have #5291 open - i think it could extend that to maybe even have a totally separated folder structure for deal related data?

@magik6k
Copy link
Contributor Author

magik6k commented Jan 27, 2021

in addition: it might be worth thinking about an extra folder for these "sealed"-unsealed sectors so miners can link storage to the folder that doesn't need to be local and does not interfere with the "normal" unsealed folder

Those unsealed files get moved to long term storage (--store) in the Finalize step

@magik6k magik6k added this to In Review in Lotus+Actors Board via automation Feb 3, 2021
@magik6k
Copy link
Contributor Author

magik6k commented Feb 3, 2021

(will add the other option in a separate PR)

@magik6k magik6k merged commit 1e7a107 into master Feb 3, 2021
Lotus+Actors Board automation moved this from In Review to Closed Feb 3, 2021
@magik6k magik6k deleted the feat/keep-unsealed-cfg branch February 3, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants