ipfsbstore: Fix has for non-existing blocks #5492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5361
Discovered this when doing something unrelated on top of this blockstore
Basically the implementation of
blockstore.Haswould callblock/staton the ipfs node - doing that in online mode will obviously try to fetch that node from the network. This then compounds with the default blockservice implementation, which callsHasbefore callingPut, which is basically guaranteed to hang in online mode when trying to retrieve data into ipfs which can't be fetched from the ipfs network (also means that data would be fetched from ipfs first before being retrieved from filecoin..)