Feat/api no dep build #5729
Merged
Feat/api no dep build #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
feat/api-no-dep-build
branch
from
9b1e639
to
49657a1
Compare
whyrusleeping
force-pushed
the
feat/api-no-dep-build
branch
from
49657a1
to
e7a1d72
Compare
Stebalien
approved these changes
Mar 9, 2021
Stebalien
force-pushed
the
feat/api-no-dep-build
branch
from
d93359e
to
dedf0ba
Compare
Stebalien
approved these changes
Mar 9, 2021
magik6k
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the api packages dependency on the build package, which transitively removes its dependency on the chain/actors/policy package which depends on every single version of the specs actors, which is a fairly bad time for people who just want to use the lotus api.
further extractions coming as my quest to have a very lightweight api package continues.