Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the AlwaysKeepUnsealedCopy flag to true #5743

Merged
merged 1 commit into from Mar 14, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Mar 8, 2021

No description provided.

@Stebalien
Copy link
Member

I guess this is an OK stop-gap but something is fishy:

  1. The retrieval cost should be set such that it covers unsealing, if required.
  2. Clients should be specifying that they want fast retrieval in their deals.

Given that we don't have 1 and this is therefore hurting miners more than it helps, we might as well enable this by default.

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I continue to be uncomfortable with relying on defaults to massage things into the shape we want, but this is fine.

@arajasek arajasek merged commit c3d1534 into master Mar 14, 2021
@arajasek arajasek deleted the feat/keep-unsealed-by-default branch March 14, 2021 19:47
@magik6k magik6k mentioned this pull request Apr 13, 2021
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants