Debug mode: Make upgrade heights controllable by an envvar #5919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
Stebalien
approved these changes
Mar 31, 2021
build/params_2k.go
Outdated
| if found { | ||
| nh, err := strconv.Atoi(nhs) | ||
| if err != nil { | ||
| log.Errorf("failed to parse 'LOTUS_NORWEGIAN_HEIGHT' env var: %s", err) |
There was a problem hiding this comment.
If we fail, we should either panic or keep the default (not set it to zero).
arajasek
force-pushed
the
asr/network-configs
branch
from
fabf417
to
1205a03
Compare
Stebalien
approved these changes
Mar 31, 2021
build/params_2k.go
Outdated
| if found { | ||
| h, err := strconv.Atoi(hs) | ||
| if err != nil { | ||
| log.Errorf("failed to parse %s env var", ev) |
arajasek
force-pushed
the
asr/network-configs
branch
from
1205a03
to
fd140c3
Compare
arajasek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes testing easier for integ partners, use LOTUS_NORWEGIAN_HEIGHT