Mempool msg selection should respect block message limits #7321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
force-pushed
the
asr/msg-limit
branch
from
4a1eadb
to
f5a315a
Compare
Codecov Report
@@ Coverage Diff @@
## master #7321 +/- ##
==========================================
+ Coverage 39.54% 39.59% +0.04%
==========================================
Files 640 640
Lines 68469 68496 +27
==========================================
+ Hits 27076 27119 +43
+ Misses 36742 36721 -21
- Partials 4651 4656 +5
Continue to review full report at Codecov.
|
vyzo
reviewed
Sep 13, 2021
magik6k
approved these changes
Nov 24, 2021
Kubuxu
approved these changes
Dec 13, 2021
|
|
||
| // one last sanity check | ||
| if len(sm.msgs) > build.BlockMessageLimit { | ||
| sm.msgs = sm.msgs[:build.BlockMessageLimit] |
There was a problem hiding this comment.
Log warning or error because this means that the code is wrong.
arajasek
force-pushed
the
asr/msg-limit
branch
from
f5a315a
to
a45803d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.