Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to actors master #7404

Merged
merged 4 commits into from Sep 30, 2021
Merged

Update to actors master #7404

merged 4 commits into from Sep 30, 2021

Conversation

arajasek
Copy link
Contributor

Highlights are:

  • Support the new PublishStorageDealsReturn type, abstracting it
  • Minor tooling changes for the WithdrawBalance change
  • Consume changes to ConfirmSectorProofsValid

@arajasek arajasek requested a review from a team as a code owner September 30, 2021 01:31
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #7404 (8756df2) into feat/nv14 (c3c46e9) will increase coverage by 0.01%.
The diff coverage is 46.52%.

Impacted file tree graph

@@              Coverage Diff              @@
##           feat/nv14    #7404      +/-   ##
=============================================
+ Coverage      39.27%   39.29%   +0.01%     
=============================================
  Files            627      627              
  Lines          66133    66248     +115     
=============================================
+ Hits           25977    26034      +57     
- Misses         35662    35707      +45     
- Partials        4494     4507      +13     
Impacted Files Coverage Δ
cli/wallet.go 0.00% <0.00%> (ø)
cmd/lotus-miner/actor.go 7.94% <0.00%> (-0.16%) ⬇️
cmd/lotus-shed/actor.go 0.00% <0.00%> (ø)
markets/storageadapter/client.go 40.55% <35.71%> (-1.53%) ⬇️
extern/storage-sealing/currentdealinfo.go 71.17% <60.00%> (-5.68%) ⬇️
chain/gen/genesis/miners.go 55.86% <68.42%> (+0.37%) ⬆️
chain/actors/builtin/market/v5.go 45.16% <77.77%> (+2.55%) ⬆️
chain/actors/builtin/market/v6.go 45.16% <77.77%> (+2.55%) ⬆️
chain/actors/builtin/market/market.go 64.21% <83.33%> (+4.47%) ⬆️
chain/stmgr/call.go 67.87% <0.00%> (-3.64%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c46e9...8756df2. Read the comment docs.

}

// TODO: Can we delete this? We're well past the point when we first introduced the proposals into sealing deal info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@arajasek arajasek merged commit 89d61ca into feat/nv14 Sep 30, 2021
@arajasek arajasek deleted the asr/specs-update branch September 30, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants