Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check manual-stateless-deal with interactive deal making #7560

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

emf-developer
Copy link
Contributor

add check manual-stateless-deal with interactive deal making as --manual-stateless-deal can not be combined with interactive deal mode.

fix checking manual-stateless-deal with interactive deal making as --manual-stateless-deal can not be combined with interactive deal mode.
@emf-developer emf-developer requested a review from a team as a code owner October 26, 2021 10:39
Copy link
Contributor

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I definitely missed that
( no idea what lint is unhappy about... )

@jennijuju
Copy link
Member

need make gen (and potentially gofmt

@emf-developer
Copy link
Contributor Author

Can / Should I do something to pass these failed tests?

@emf-developer
Copy link
Contributor Author

@jennijuju @ribasushi

@magik6k
Copy link
Contributor

magik6k commented Nov 4, 2021

Can / Should I do something to pass these failed tests?

Yes, run go fmt ./..., then commit changes

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #7560 (135186e) into master (a94a48f) will decrease coverage by 0.07%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7560      +/-   ##
==========================================
- Coverage   39.90%   39.83%   -0.08%     
==========================================
  Files         633      633              
  Lines       67098    67101       +3     
==========================================
- Hits        26776    26728      -48     
- Misses      35723    35771      +48     
- Partials     4599     4602       +3     
Impacted Files Coverage Δ
cli/client.go 22.84% <25.00%> (+0.02%) ⬆️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
storage/wdpost_sched.go 75.24% <0.00%> (-11.89%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-1.96%) ⬇️
extern/sector-storage/sched.go 82.30% <0.00%> (-1.65%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a94a48f...135186e. Read the comment docs.

@emf-developer
Copy link
Contributor Author

@magik6k magik6k disabled auto-merge March 2, 2022 13:16
@magik6k magik6k merged commit 74e6260 into filecoin-project:master Mar 2, 2022
@magik6k magik6k changed the title add check manual-stateless-deal with interactive deal making fix: add check manual-stateless-deal with interactive deal making Mar 2, 2022
@silvianetobessa
Copy link

Hello @EmadMF!

This contribution to the Filecoin codebase was voted as impactful during Q1 and is eligible for a FIL prize as part of a Protocol Labs experiment to reward open source contributions from the community (see full details here).

Please reach out to us through commons@protocol.ai to receive the instructions on how to claim your reward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants