Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wdpost worker: Reduce challenge confidence to 1 epoch #7572

Merged
merged 1 commit into from Nov 22, 2021
Merged

Conversation

arajasek
Copy link
Contributor

This confidence was introduced in #5764 as a stopgap until #3613 was fixed, which happened in the chocolate upgrade.

It is now strictly unnecessary and the 5 minutes can be spent on PoSt computation. We could kill it entirely, or leave it at 1 epoch.

@arajasek arajasek requested a review from a team as a code owner October 27, 2021 15:35
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #7572 (6455b0e) into master (d9fd1d9) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7572      +/-   ##
==========================================
- Coverage   39.89%   39.77%   -0.13%     
==========================================
  Files         633      633              
  Lines       67098    67098              
==========================================
- Hits        26771    26685      -86     
- Misses      35731    35821      +90     
+ Partials     4596     4592       -4     
Impacted Files Coverage Δ
storage/wdpost_changehandler.go 98.11% <ø> (-0.48%) ⬇️
chain/actors/builtin/market/v5.go 23.38% <0.00%> (-16.13%) ⬇️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
storage/wdpost_sched.go 81.18% <0.00%> (-5.95%) ⬇️
markets/storageadapter/ondealsectorcommitted.go 77.33% <0.00%> (-4.00%) ⬇️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
chain/actors/builtin/miner/v5.go 35.69% <0.00%> (-2.47%) ⬇️
extern/sector-storage/stores/local.go 57.30% <0.00%> (-1.97%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9fd1d9...6455b0e. Read the comment docs.

@magik6k magik6k merged commit 5b7bf6c into master Nov 22, 2021
@magik6k magik6k deleted the asr/post branch November 22, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants