Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial retrieval ux improvements #7610

Merged
merged 34 commits into from Nov 24, 2021
Merged

Partial retrieval ux improvements #7610

merged 34 commits into from Nov 24, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 9, 2021

TODO:

@magik6k magik6k requested a review from a team as a code owner November 9, 2021 12:36
@magik6k magik6k marked this pull request as draft November 9, 2021 12:36
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #7610 (bd4927b) into master (3714177) will decrease coverage by 0.25%.
The diff coverage is 34.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7610      +/-   ##
==========================================
- Coverage   39.60%   39.35%   -0.26%     
==========================================
  Files         635      637       +2     
  Lines       67581    67928     +347     
==========================================
- Hits        26767    26733      -34     
- Misses      36217    36571     +354     
- Partials     4597     4624      +27     
Impacted Files Coverage Δ
api/api_full.go 47.36% <ø> (ø)
api/types.go 52.77% <ø> (ø)
api/v0api/full.go 0.00% <0.00%> (ø)
api/v0api/v1_wrapper.go 1.14% <0.00%> (-1.08%) ⬇️
cli/client.go 21.31% <ø> (-1.52%) ⬇️
node/rpc.go 27.41% <12.50%> (-3.59%) ⬇️
cli/client_retr.go 21.53% <21.53%> (ø)
node/impl/client/client.go 50.06% <64.39%> (+4.94%) ⬆️
itests/kit/deals.go 77.68% <80.00%> (-0.30%) ⬇️
node/modules/storageminer.go 57.44% <100.00%> (-5.67%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3714177...bd4927b. Read the comment docs.

@magik6k
Copy link
Contributor Author

magik6k commented Nov 22, 2021

Examples of the new commands:
2021-11-17-202028_1948x1260_scrot

api/types.go Outdated Show resolved Hide resolved
@magik6k magik6k marked this pull request as ready for review November 23, 2021 18:00

if p.LastBlock.Link == nil {
// this is likely the root node that we've matched here
// todo: is this a correct assumption
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@magik6k magik6k merged commit 58dd814 into master Nov 24, 2021
@magik6k magik6k deleted the feat/partret-ux branch November 24, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants