Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove jaeger envvars #7631

Merged
merged 1 commit into from Nov 18, 2021
Merged

remove jaeger envvars #7631

merged 1 commit into from Nov 18, 2021

Conversation

coryschwartz
Copy link

This was causing excessive logging when jaeger wasn't available.

When it is available, you can add these env vars on your own, but usually best to leave them unset.

fixes: #7502

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #7631 (2894567) into master (e196a81) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7631      +/-   ##
==========================================
- Coverage   39.78%   39.70%   -0.08%     
==========================================
  Files         633      633              
  Lines       67258    67258              
==========================================
- Hits        26756    26704      -52     
- Misses      35910    35950      +40     
- Partials     4592     4604      +12     
Impacted Files Coverage Δ
chain/gen/slashfilter/slashfilter.go 40.00% <0.00%> (-12.00%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-11.77%) ⬇️
extern/sector-storage/manager_calltracker.go 57.70% <0.00%> (-4.85%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-1.89%) ⬇️
itests/kit/blockminer.go 93.65% <0.00%> (-1.59%) ⬇️
lib/rpcenc/reader.go 70.29% <0.00%> (-1.49%) ⬇️
miner/miner.go 57.28% <0.00%> (-1.33%) ⬇️
extern/storage-sealing/fsm.go 55.77% <0.00%> (-1.20%) ⬇️
chain/messagepool/messagepool.go 57.79% <0.00%> (-0.87%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e196a81...2894567. Read the comment docs.

@magik6k magik6k merged commit ef0771e into master Nov 18, 2021
@magik6k magik6k deleted the remove-jaeger-envvars branch November 18, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dockerfile excessive jaeger logging
2 participants