Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ci: packer snap #7819

Merged
merged 13 commits into from
Mar 2, 2022
Merged

feat: ci: packer snap #7819

merged 13 commits into from
Mar 2, 2022

Conversation

coryschwartz
Copy link

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@coryschwartz
Copy link
Author

This changes the snap package so it can be used on digitalocean as a service

The snap package will install a service rather than just commandline tools, meaning lotus daemon is running in the background, enabled at boot.

commandline tools for the miner, worker, and lotus are of course installed as part of the snap. The lotus commandline is configured to interact with the local daemon by default, and can be made to use another daemon or gateway with environment variables, as usual.

Included in this PR is a change to the digitalocean image, this will make a digitalocean image install the snap package rather than copying the lotus binaries. This way, we do not need to update the digitalocean image when there are new releases. Simply by updating the snap package, the digitalocean images will start using the updated snap.

@coryschwartz coryschwartz marked this pull request as ready for review January 19, 2022 20:43
@coryschwartz coryschwartz requested a review from a team as a code owner January 19, 2022 20:43
@coryschwartz
Copy link
Author

If you'd like to try out the images created with this change, see lotus-mainnet-snap-20220119015458 in the DO account.

@coryschwartz
Copy link
Author

Sorry for the delay, should be good to go now.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #7819 (cdd2d5c) into master (9429229) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7819      +/-   ##
==========================================
- Coverage   39.48%   39.42%   -0.07%     
==========================================
  Files         666      666              
  Lines       72498    72498              
==========================================
- Hits        28627    28583      -44     
- Misses      38915    38948      +33     
- Partials     4956     4967      +11     
Impacted Files Coverage Δ
cli/util.go 41.66% <0.00%> (-8.34%) ⬇️
markets/retrievaladapter/client_blockstore.go 62.50% <0.00%> (-6.25%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-3.64%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-2.57%) ⬇️
extern/sector-storage/sched.go 83.12% <0.00%> (-2.47%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-1.97%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-1.70%) ⬇️
miner/miner.go 56.72% <0.00%> (-1.32%) ⬇️
extern/storage-sealing/fsm.go 56.44% <0.00%> (-1.05%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9429229...cdd2d5c. Read the comment docs.

@magik6k magik6k changed the title packer snap feat: ci: packer snap Mar 2, 2022
@magik6k magik6k merged commit 91ae72d into master Mar 2, 2022
@magik6k magik6k deleted the digitalocean-use-snap branch March 2, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants