Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: wallet: wallet tests with annotations for system test matrix #7928

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

TheMenko
Copy link
Contributor

Related Issues

This PR adds two tests for wallet with annotations that are being used with system test matrix (stm)

Proposed Changes

Tests for local and multi wallet

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

t.Fatal(err)
}

if addr != a1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity this should move above the delete step

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #7928 (77bf46d) into master (5d416de) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7928      +/-   ##
==========================================
+ Coverage   39.91%   39.93%   +0.02%     
==========================================
  Files         666      666              
  Lines       72554    72554              
==========================================
+ Hits        28963    28978      +15     
+ Misses      38553    38512      -41     
- Partials     5038     5064      +26     
Impacted Files Coverage Δ
markets/loggers/loggers.go 88.88% <0.00%> (-11.12%) ⬇️
cli/util.go 70.83% <0.00%> (-8.34%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
storage/wdpost_sched.go 77.45% <0.00%> (-3.93%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-3.64%) ⬇️
blockstore/autobatch.go 56.30% <0.00%> (-1.69%) ⬇️
lib/rpcenc/reader.go 70.29% <0.00%> (-1.49%) ⬇️
miner/miner.go 56.72% <0.00%> (-1.32%) ⬇️
chain/vm/vm.go 61.63% <0.00%> (-1.07%) ⬇️
extern/storage-sealing/fsm.go 56.44% <0.00%> (-1.05%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d416de...77bf46d. Read the comment docs.

@magik6k magik6k merged commit 949a046 into master Feb 25, 2022
@magik6k magik6k deleted the bloxico/basic_wallet_tests branch February 25, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants