Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't track peer ids in rcmgr metrics #8099

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Feb 15, 2022

follow up from #8089 -- don't track things that come from the network, as the metrics subsystem is not exactly bulletproof and can end up using uncontrolled memory because of spam under high load conditions.

@vyzo vyzo requested a review from a team as a code owner February 15, 2022 14:13
@vyzo vyzo requested a review from magik6k February 15, 2022 14:14
@vyzo vyzo added this to the v1.15.0 milestone Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #8099 (9c00af1) into master (a3e785c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8099   +/-   ##
=======================================
  Coverage   39.33%   39.34%           
=======================================
  Files         666      666           
  Lines       72468    72462    -6     
=======================================
+ Hits        28503    28507    +4     
+ Misses      39043    39026   -17     
- Partials     4922     4929    +7     
Impacted Files Coverage Δ
node/modules/lp2p/rcmgr.go 16.19% <ø> (+0.87%) ⬆️
extern/sector-storage/worker_tracked.go 79.46% <0.00%> (-7.15%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-3.64%) ⬇️
blockstore/autobatch.go 56.30% <0.00%> (-1.69%) ⬇️
extern/sector-storage/sched.go 83.12% <0.00%> (-1.65%) ⬇️
chain/store/store.go 63.66% <0.00%> (-1.34%) ⬇️
chain/gen/gen.go 68.19% <0.00%> (-1.23%) ⬇️
miner/miner.go 54.75% <0.00%> (-0.99%) ⬇️
chain/messagepool/messagepool.go 63.15% <0.00%> (-0.86%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e785c...9c00af1. Read the comment docs.

@magik6k magik6k merged commit fd66c0d into master Feb 15, 2022
@magik6k magik6k deleted the feat/rcmgr-metrics-redux branch February 15, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants