Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: itests: add itests ensemble mocknet getter #8157

Merged

Conversation

elijaharita
Copy link
Contributor

@elijaharita elijaharita commented Feb 18, 2022

Related Issues

We want FilClient to use itests ensemble for tests. It requires access to the mocknet object inside of ensemble, so that it can hook into the offline network, which is currently private.

Proposed Changes

Add a public getter for itests ensemble mocknet.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@elijaharita elijaharita requested a review from a team as a code owner February 18, 2022 21:26
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #8157 (e2a93a3) into master (9429229) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8157      +/-   ##
==========================================
- Coverage   39.48%   39.46%   -0.02%     
==========================================
  Files         666      666              
  Lines       72498    72500       +2     
==========================================
- Hits        28627    28615      -12     
- Misses      38915    38928      +13     
- Partials     4956     4957       +1     
Impacted Files Coverage Δ
itests/kit/ensemble.go 90.76% <0.00%> (-0.49%) ⬇️
cli/util.go 41.66% <0.00%> (-8.34%) ⬇️
markets/retrievaladapter/client_blockstore.go 62.50% <0.00%> (-6.25%) ⬇️
chain/actors/builtin/miner/diff.go 52.94% <0.00%> (-5.89%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/exchange/client.go 52.96% <0.00%> (-1.70%) ⬇️
blockstore/autobatch.go 56.30% <0.00%> (-1.69%) ⬇️
miner/miner.go 56.72% <0.00%> (-1.32%) ⬇️
chain/stmgr/searchwait.go 68.58% <0.00%> (-1.29%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9429229...e2a93a3. Read the comment docs.

@magik6k magik6k merged commit 7351939 into filecoin-project:master Feb 20, 2022
@elijaharita elijaharita deleted the feat/ensemble-mocknet-getter branch March 31, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants